| Re: [AD] ALSA RawMIDI fixes |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On 2007-02-02, Peter Wang <tjaden@xxxxxxxxxx> wrote:
> Hi,
>
> I noticed some behaviour in the ALSA rawmidi driver, which I think is wrong.
> The alsa_rawmidi_output() method currently puts a detailed error message into
> allegro_error when the call to snd_rawmidi_write() fails. However, this
> method is probably most often called from a timer interrupt, due to
> play_midi(). The user might call some Allegro function and expect an error
> message to be put in allegro_error, only to have it clobbered by the MIDI
> playback running in the background. Therefore I think it's best not to
> modify allegro_error in alsa_rawmidi_output().
Committed.