Re: [AD] Patch for makefile issue when compiling MSVC with Cygwin

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On Sunday 07 January 2007 8:22 am, Milan Mimica wrote:
> Andrei Ellman wrote:
> > The only thing I have my doubts about is using "ifeq ($(TERM), cygwin)"
> > to test to see if ALLEGRO_USE_CYGWIN should be set. In
> > build/mingw32.txt, it tells the user to place "export
> > ALLEGRO_USE_CYGWIN=1" in '/etc/profile'. In the interests of
> > consistency, I think we should mention this in build/msvc.txt as well so
> > we don't have to bother with ifeq ($(TERM), cygwin)
>
> We can put the "ifeq ($(TERM), cygwin)" thing in makefile.mgw too.
> Having things done automatically for the user is a good thing.

In this case, its just annoying. as is detecting sh, and setting UNIXTOOLS (or 
whatever it is.

If a user really wants it, they should set it.

>
> --
> Milan Mimica
> http://sparklet.sf.net
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share
> your opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

-- 
Thomas Fjellstrom
tfjellstrom@xxxxxxxxxx




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/