Re: [AD] OSX qtmidi.m build failure fix |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
- To: alleg-developers@xxxxxxxxxx
- Subject: Re: [AD] OSX qtmidi.m build failure fix
- From: "Peter Hull" <peterhull90@xxxxxxxxxx>
- Date: Fri, 14 Apr 2006 15:19:02 +0100
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=CoEGibLX2YXktem+FtOSrPuYauYzoDnA+qkNmFFsIL7ZWCW4Sn5x58I6dZVoC/xecAJRsaAeiMk6IF4xFxoxBr/xBtXQ8bTL4MNpSsi9HqKv12+FEuA6hUv1p3Ec2Ti0IyiBSwlT3y++8YFQMjdGhXVACCrmjV7Y2coZ6qCi1mU=
I just don't think that's the best way to do it. Please can someone
test what I wrote in my previous email.
EndianU16_NtoB() and friends are _designed_ to overcome differences in
processors, it seems unnecessary to be wrapping things in #ifdefs.
Pete
On 4/14/06, Elias Pschernig <elias@xxxxxxxxxx> wrote:
> On Fri, 2006-04-14 at 17:21 +0800, Miguel A. Gavidia wrote:
> > On Friday 14 April 2006 07:13, Jay Bernardo wrote:
> > > This is my first attempt at flagging something as broken and
> > > supplying a patch to fix it. If I improperly followed procedure,
> > > please let me know.
> > >
> > > When building Allegro for MacOS X from the 4.2 branch (revision 5777)
> > > the following errors occur:
> > >
> > > src/macosx/qtmidi.m: In function 'osx_midi_init':
> > > src/macosx/qtmidi.m:128: error: request for member 'bigEndianValue'
> > > in something not a structure or union
> > > src/macosx/qtmidi.m:129: error: request for member 'bigEndianValue'
> > > in something not a structure or union
> > >
> > > Below is a diff of a fix that remedies the problem. Testing may be
> > > required, as I'm not sure exactly what should be tested to ensure it
> > > does everything correctly. My poor test consisted of running exmidi
> > > and verifying that it properly plays a midi file.
> > >
>
> Ok, committed it, after discussion in #allegro.
>
> --
> Elias Pschernig
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language
> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> --
> https://lists.sourceforge.net/lists/listinfo/alleg-developers
>