[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
- To: alleg-developers@xxxxxxxxxx
- Subject: Re: [AD] OSX x86 patch
- From: "Peter Hull" <peterhull90@xxxxxxxxxx>
- Date: Sat, 8 Apr 2006 17:40:10 +0100
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=k/xpYw3QY24W3ghoR7Pk5zKo/bM/TWy/qzP853p6fO8oUqf4bgpwdpH0w78MDyr/TkUKyqLeo8F6d6xUsB84UA2Cjz9t+rGhCV3B0Ohvo1ezWDoCHssfexGskw8ZGrNqDDY/T7lFQCD0QxmbGk6XUf0SxUuXAdh8w4nHJFe3R9s=
I think the changes to qtmidi.m aren't necessary because
Endian*_NtoB() means 'Convert Native to Big-endian' i.e. they are
already platform-specific. Therefore they won't need #ifdef __i386
around them.
The other thing to consider is - what is meant by ALLEGRO_I386 (and
ALLEGRO_AMD64, ALLEGRO_ARM etc)? Is it purely that you are compiling
on that type of processor, or that you have the processor _and_
allegro is using assembly code for it? It's a bit mixed up at the
moment.
After some comments from Kitty, I would say the former, so we'd have
logic like this
#ifndef ALLEGRO_NO_ASM
#ifdef ALLEGRO_I386
/* 386 version of function*/
#endif
#ifdef ALLEGRO_AMD64
/* amd version */
#endif
...
#else
/* C version */
#endif
.. but this isn't quite right as we would want to fallback to the C
version if there was no asm version available for a particular
platform.
Pete
Pete
On 4/8/06, Elias Pschernig <elias@xxxxxxxxxx> wrote:
> On Sat, 2006-04-08 at 11:50 +0800, Miguel A. Gavidia wrote:
> > I went through and added some changes to get allegro to build on OSX x86,
> > which after the changes compiles and installs soundly.
> > I also reviewed the thread concerning ALLEGRO_USE_C and took into
> > consideration that if ALLEGRO_USE_C is explicitly declared the assumption is
> > that no ASM is desired. With the OSX build of allegro that it is statically
> > set so there should be no qualms regarding usage of ASM.
> > The patch otherwise shouldn't effect the usage of ASM if ALLEGRO_USE_C is
> > never set on other platforms.
> > Look over the patch and see if it is feasible.
> > Thanks. :)
>
> Hm, this reminds me.. should I now commit that patch to completely get
> rid of ALLEGRO_USE_C? (Which would make the last part of your patch
> unnecessary.)
>
> --
> Elias Pschernig
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language
> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> --
> https://lists.sourceforge.net/lists/listinfo/alleg-developers
>