Re: [AD] PATCH: updated mprotect patch for allegro-4.2.1 which also work on Linux

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On Sunday 12 March 2006 10:25, Hans de Goede wrote:
> > C99 and Allegro define uintptr_t for casting pointers to int types. 
Would 
> > probably be better if you used that instead.
> 
> Makes no difference this always hold: sizeof(long) == sizeof(void *)

It may make no difference now, but there is nothing in the C standard that 
says that this should be true. Best to use the proper C99 type for this; 
it's there, afterall.
Could you make a clean patch that doesn't contain the other OpenBSD fixes? 
That will make it a bit easier to commit.

Evert




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/