Re: [AD] get volume

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On Sun, 2006-03-12 at 10:51 +0100, Elias Pschernig wrote:
> On Thu, 2006-03-02 at 15:20 +0100, Evert Glebbeek wrote:
> > > Maybe if it simply is added at the end of the struct instead of in the
> > > middle?
> > 
> > That still changes the size of the struct. I don't know if it's a problem in 
> > this case (if it's only used internally, it shouldn't be, I suppose), but 
> > it's something that must be checked.
> > It's also definately safer to put it at the end of the struct (because we have 
> > a chance of the compiler initialising it to NULL and it thus being ignored at 
> > runtime, in case we forget to update one of the vtables).
> 
> If we assume that a sound driver is only created and accessed by
> Allegro, the patch can be applied as is, I think.
> 

I checked all the headers, and it seems digi_driver is never used in an
inline or macro function. So, I committed it unmodified for now.

-- 
Elias Pschernig





Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/