| Re: [AD] Re: binary compatibility check |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Fri, 2006-02-17 at 19:20 +0100, Elias Pschernig wrote:
> On Wed, 2006-02-08 at 11:29 +0100, Elias Pschernig wrote:
> > Since this code looks so ugly now though, I'm wondering about changing
> > _install_allegro to get a 4th parameter with the compile-time version,
> > and then simply have this:
> >
> > #define allegro_init _install_allegro(SYSTEM_AUTODETECT, errno, atexit, MAKE_VERSION(...))
> >
> > And let install_allegro again be a normal function, which simply calls
> > _install_allegro. It would mean, only allegro_init could do the version
> > check, but that should be enough, and all involved code stays clean.
>
> The attached patch does just that. I left the current allegro_install
> intact, since I'm not sure how changing an AL_INLINE function to a
> normal function affects binary compatibility.
>
Oh, and KittyCat just pointed out in #allegro that
_install_allegro_version_check can also be called frin install_allegro,
so when applying the patch, install_allegro would be modified to look
like install_allegro, and the comment removed.
--
Elias Pschernig