| Re: [AD] list_config_entries |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Sat, 2005-12-31 at 11:42 +1100, Peter Wang wrote:
> On 2005-11-27, Elias Pschernig <elias@xxxxxxxxxx> wrote:
> > Attached again a patch I sent some months ago, against new_api_branch..
> > I'm not sure how well it will fit into the new config system, but I find
> > it useful right now.
>
> Sorry about the late reply.
Well, thanks for looking over it.
[..]
> This is no good. The malloc() that the Allegro DLL uses may not be
> compatible with the free() from the user program. You must either
> provide free_config_entries_list() function or pass the implementation
> of malloc() to list_config_sections(), e.g. by making it a macro like
> ustrdup(). I much prefer the former.
Ok, I added a free_config_entries function, expecting a pointer in the
same format as the other two functions.
> You forgot to add function prototypes for list_config_entries() and
> list_config_sections().
>
Ok, done.
> Peter
>
> PS. Please write more descriptive log messages.
>
Yes, definitly should have listed the added functions.
--
Elias Pschernig