| Re: [AD] [ alleg-Bugs-1263730 ] key_shifts does not work with win95/98/me |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Sat, 2005-08-27 at 00:16 +0200, Evert Glebbeek wrote:
> On Saturday 27 August 2005 00:13, Elias Pschernig wrote:
> > Anyway, attached is a really trivial patch which should fix it, but it
> > is completely untested. So, someone with win98 should now verify that
> > key_shifts works correctly with it (e.g. in exkeys), and someone with XP
> > that it still works there as well.
>
> Why not replace either of
>
> - if ((keystate[VK_LSHIFT] & 0x80) || (keystate[VK_RSHIFT] & 0x80))
> + if (keystate[VK_SHIFT] & 0x80)
>
> with
>
> if ((keystate[VK_LSHIFT] & 0x80) || (keystate[VK_RSHIFT] & 0x80) ||
> (keystate[VK_SHIFT] & 0x80))
>
> &c to have both? Or is that overkill?
>
Well, in the unlikely case XP requires the L/R versions, then yes. Else,
it is overkill.
--
Elias Pschernig