| Re: [AD] Inline file function |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On 2005-06-24, Elias Pschernig <elias@xxxxxxxxxx> wrote:
> On Fri, 2005-06-24 at 18:45 +0200, Hrvoje Ban wrote:
> > For some strange reason pack_fclose/read/write/seek/ugetc were put
> > inside file.c when they should be in file.inl. This patch fix this
> > with pack_fclose as exception because it uses free_packfile (static
> > function in file.c).
>
> Well, I very much doubt you can provide a testcase which shows any
> significant speedup with the change. Still, looks more consistent that
> way, so I guess it should be applied.
I pulled it out of file.inl on purpose. Those operations all go through
the vtable now, so there's nothing much to gain by inlining.
Peter