Re: [AD] freeze on exit in windows

[Elias Pschernig <elias@xxxxxxxxxx>]

On Sun, 2005-05-01 at 15:52 +0200, Evert Glebbeek wrote:
> On Wednesday 27 April 2005 17:18, Elias Pschernig wrote:
> > The old problem.. should be fixed by the attached patch. It does 2
> > things: Enables the timer mutexes, and replaces the INFINITE when
> > waiting for the thread with a loop. Why the loop is necessary, I don't
> > know. but the MSDN docs tell you to not use INFINITE when calling
> > CoInitialize (which we do), and their example uses a loop like this as
> > well.
> 
> Commited in two steps.
> The Windows part I don't doubt that you tested sufficiently, but are you 
> sure the multi-threading code in src/timer.c works well in MacOSX?
> The previous define would have disabled multi threading in both Windows and 
> OSX, so removing it now enables it in both.
> 

Hm, yes, I didn't test how much related they are. I first removed the
#define in timer.c, after that I debugged the WaitForSingleObject. I
guess, they could actually be two unrelated problems.

Anyway, I'd still completely remove the #define in timer.c, since not
using the timer mutexes in a multithreaded port simply is wrong - see
the mouse related problems in that allegro.cc thread which were caused
by it. That had nothing to do with anything driver specific.. so surely
the same must happen on OSX without the #define.

-- 
Elias Pschernig