Re: [AD] GCC 4 warnings for MacOS X

[Peter Wang <tjaden@xxxxxxxxxx>]

On 2005-05-15, Charles Wardlaw <kattkieru@xxxxxxxxxx> wrote:
> Hiya,
> 
> Actually, your patch just moved the warnings from line 172 to line 142.
>  The type of the variable can't be changed without a typecast as one
> function requires it to be signed and another unsigned.
> 
> Here's five patches.  I've gone through the mac os x warnings and
> removed all but one: the one in src/macosx/system.m. I don't understand
> it, exactly:

Cheers.  Committed all the patches except this:

> --- src/macosx/main.m	Sun Jul 11 12:15:30 2004 UTC
> +++ src/macosx/main.m	Mon May 16 04:32:54 2005 UTC
> @@ -223,7 +223,7 @@
>        keyEquivalent: @""];
>     [[NSApp mainMenu] addItem: temp_item];
>     [[NSApp mainMenu] setSubmenu: menu forItem: temp_item];
> -   [NSApp setAppleMenu: menu];
> +   //   [NSApp setAppleMenu: menu];
>     NSString *quit = @"Quit ";
>     menu_item = [[NSMenuItem allocWithZone: [NSMenu menuZone]]
>        initWithTitle: [quit stringByAppendingString: [[NSProcessInfo processInfo] processName]]

I realise that the setAppleMenu method seems to have disappeared (!).
Is it okay just to comment out that call?  What was it supposed to do?

Peter