Re: [AD] timer_mutex again

[Eric Botcazou <ebotcazou@xxxxxxxxxx>]

> So thread 4 is holding the timer_mutex in _handle_timer_tick() and
> wanting to get the _xwin.mutex.  Meanwhile thread 1 has the _xwin.mutex
> (due to an acquire_screen in dialog_message) and wants the timer_mutex.

Thanks.  I think dialog_message is wrong, it should not acquire_screen.  
AFAICS object_message already has the necessary bits.

scare_mouse clearly cannot be invoked when the screen has been acquired.

> >The idea was to make sure that all callbacks have completed before
> > remove_int returns.  Does your proposed change still guarantee that?
>
> No :-(  Actually, the same problem is marked FIXME in the new_api_branch
> so I should have remembered it.

I should have documented it in timer.c.

-- 
Eric Botcazou