Re: [AD] ICL/MSVC documentation patch

[AJ <aj@xxxxxxxxxx>]

if marked a few problems that i found:





Index: makefile.vc
===================================================================
RCS file: /cvsroot/alleg/allegro/makefile.vc,v
retrieving revision 1.63
diff -u -r1.63 makefile.vc
--- makefile.vc	28 Mar 2005 12:23:46 -0000	1.63
+++ makefile.vc	29 Mar 2005 21:33:30 -0000
@@ -5,6 +5,12 @@
 #  To path MSVC so it can be used from the commandline, run the
 #  vcvars32.bat file which can be found in your MSVC bin directory.
 #
+#  To use MSVC specific options, the variable COMPILER_MSVC7 must be




maybe it should say  'use MSVC7 specific'



set. The
+#  fix.bat script should do this automatically if run as `fix --msvc7'
+#




its just   fix msvc7  the '--' is not required.





+#  To use the Intel commandline compiler instead of the MSVC compiler,
+#  COMPILER_ICL must be set. Again, `fix --icl' should take care of




i think 'fix icl' is probably what is required, the '--' is not required.




this.
+#
 #  This platform uses GCC for building the assembler sources and 
calculating
 #  source dependencies, so you'll need to have that installed in the 
form of
 #  DJGPP, MinGW or Cygwin.
@@ -122,7 +128,11 @@

 # -------- Work out the absolute pathnames for some MSVC tools to 
avoid confusion --------

-MSVC_CL = $(MSVCDIR_U)/bin/cl
+ifdef COMPILER_ICL
+   MSVC_CL = icl
+else
+   MSVC_CL = $(MSVCDIR_U)/bin/cl
+endif
 MSVC_LINK = $(MSVCDIR_U)/bin/link
 MSVC_LIB = $(MSVCDIR_U)/bin/lib
 MSVC_RC = rc
@@ -172,11 +182,17 @@

 # -------- optimised build --------

-CFLAGS = $(WFLAGS) -Gd -O2 -GB $(RUNTIME_FLAGS)
+CFLAGS = $(WFLAGS) -Gd $(RUNTIME_FLAGS)
 SFLAGS = -Wall
 LFLAGS = -release
 LIBPARMS =

+ifdef COMPILER_ICL
+   CFLAGS += -Os -G7 -QaxPN
+else
+   CFLAGS += -O2 -GB
+endif




there was a patch that i submitted that removed the -GB  from the CFLAGS 
line (for MSVC7) and added this

ifdef TARGET_ARCH_EXCL
	CFLAGS += -G$(TARGET_ARCH_EXCL)
else
	CFLAGS += -GB
endif


so that the user could select p4/Athlon-Xp specific optimz, and if the 
user does not specify the TARGET_ARCH_EXCL it will default back to -GB 
(PPro/P2/P3)




the rest looks OK.
thank you for changing optimilization :)

aj.