| Re: [AD] XOR drawing under X11 (and what is _xwin_in_gfx_call) |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Thu, 2004-11-25 at 16:57 -0800, Chris wrote:
> The patch looks mostly alright. A few things though.. The direct_*
> functions should probably be prefixed with _xwin just like all the other
> X11 functions. You also missed tagging them as inline. I also think
> drawing_mode_ok should only be set TRUE if matching_formats is true as
> well as _drawing_mode is DRAW_MODE_SOLID (this will make it so you only
> have to test drawing_mode_ok instead of both that and matching_formats).
>
> I attached an updated patch.
>
Applied your patch, with a slight change to update _xwin.drawing_mode_ok
on mode changes (_xwin.matching_format may change there). This fixes the
XOR drawing issues.
--
Elias Pschernig