Re: [AD] version check in allegro_init |
[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]
Evert Glebbeek wrote:
Not sure this is needed - but Evert and me tracked down a problem someone had on allegro.cc yesterday which made seemingly no sense, and it turned out to be a version conflict between two WIP versions.I think this is a problem that occurs quite often and the check is easy to do from our end. Sure, the problem is usually the user forgetting to uninstall the previous version before the new version or some such thing, but if we can make it easier for them to spot the problem then I think we should.
Agreed.
The attached patch is a very simple check which would have caught this (allegro_init checks if it is a WIP version, and fails if the version differs in that case).Looks good to me. Guess we need to document install_allegro_subversion.
Do we really need to make the check optional? We could just put the check into install_allegro() and if the versions don't match we can show a message using allegro_message() and return an error code.
Peter
Mail converted by MHonArc 2.6.19+ | http://listengine.tuxfamily.org/ |