Re: [AD] GCC 3.4

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


> windres --include-dir include -O coff -o obj/mingw32/alleg/dllver.o -i
> src/win/dllver.rc
>
> windres: src/win/dllver.rc:1: parse error
>
> make: *** [obj/mingw32/alleg/dllver.o] Error 1

I can't reproduce with windres 2.15.90 20040222.

> src/win/wddbmp.c: In function `create_directdraw2_surface':
>
> src/win/wddbmp.c:243: warning: dereferencing type-punned pointer will
> break strict-aliasing rules

Fixed by the attached patch, applied to mainline and 4.0 branch.

-- 
Eric Botcazou
Index: src/win/wddbmp.c
===================================================================
RCS file: /cvsroot/alleg/allegro/src/win/wddbmp.c,v
retrieving revision 1.31
diff -u -r1.31 wddbmp.c
--- src/win/wddbmp.c	17 Sep 2003 13:12:26 -0000	1.31
+++ src/win/wddbmp.c	29 Feb 2004 09:38:17 -0000
@@ -168,7 +168,7 @@
 {
    DDSURFACEDESC ddsurf_desc;
    LPDIRECTDRAWSURFACE ddsurf1;
-   LPDIRECTDRAWSURFACE2 ddsurf2;
+   LPVOID ddsurf2;
    HRESULT hr;
 
    /* describe surface characteristics */
@@ -240,7 +240,7 @@
    }
 
    /* retrieve the DirectDrawSurface2 interface */
-   hr = IDirectDrawSurface_QueryInterface(ddsurf1, &IID_IDirectDrawSurface2, (LPVOID *)&ddsurf2);
+   hr = IDirectDrawSurface_QueryInterface(ddsurf1, &IID_IDirectDrawSurface2, &ddsurf2);
 
    /* there is a bug in the COM part of DirectX 3:
     *  If we release the DirectSurface interface, the actual
@@ -254,7 +254,7 @@
       return NULL;
    }
 
-   return ddsurf2;
+   return (LPDIRECTDRAWSURFACE2)ddsurf2;
 }
 
 


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/