RE: [AD] mode selection

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


> You leak memory by setting 
> driver_list_entry->fetch_mode_list_ptr to NULL 
> while dynamically allocating the list. And I think that using dynamic 
> allocation even though there is no sieve function is inefficient.

Oops, thanks for spotting this.

> Ouch! Weird formatting...

Sorry, for large arg lists, I use parentheses like I use braces :)

> Take a look at what the function just below passes as 
> 'color_depth'. You need 
> either to remove the 4th assert or redirect gfx_mode_select().

OK

> I renamed gfx_mode_select_sieve into gfx_mode_select_filter 
> and commited the 
> attached patch to mainline.

Thanks

-- 
Vincent Penquerc'h 




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/