Re: [AD] xkeymap fix

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


> I'm about to commit the attached patch to stop xkeymap from crashing,
> since KEY_MAX was increased and someone coded xkeymap so it tries to
> display a NULL pointer in that case (/me looks away).

I'd suggest to additionally put an ASSERT that checks whether the index is 
out-of-bounds.

> Btw., is there a reason KEY_MAX is 120, but the highest key is 118?

A different counting scheme from Italy? :-)

> And what is the purpose of KEY_MODIFIERS ? If some part of the Allegro code 
> assumes only modifier keys are defined after it, something might go wrong
> with the added OSX keys..

Angelo was probably not aware of that. Do you think this can affect non-OSX 
ports?

-- 
Eric Botcazou




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/