Re: [AD] Oddity in src/linux/fbcon.c

[Grzegorz Adam Hankiewicz <gradha@xxxxxxxxxx>]

On 2003-09-12, Eric Botcazou <ebotcazou@xxxxxxxxxx> wrote:
> Here are the odd lines:
> 
> static int fb_scroll(int x, int y)
> {
>    int ret;
> 
>    my_mode.xoffset = x;
>    my_mode.yoffset = y;
> 
>    ret = ioctl(fbfd, FBIOPAN_DISPLAY, &my_mode);
> 
>    fb_vsync();
> 
>  #ifdef FBIOGET_VBLANK
>    if (!vblank_flags)
>  #endif
>       fb_vsync();
> 
>    return (ret) ? -1 : 0;
> }
> 
> 
> Note that, if FBIOGET_VBLANK is not defined, fb_vsync() will be
> invoked twice. Is this a thinko?

It doesn't seem to jurt hurt performance for me. In fact, with only
one fb_vsync animation looks more jumpy. But I can't say, I have
one of these LCD screens which are bad for any kind of animation.