| Re: [AD] Patch for rare buffer overflow of do_uconvert with tiny buffer sizes |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
- To: Allegro developers mailing list <alleg-developers@xxxxxxxxxx>
- Subject: Re: [AD] Patch for rare buffer overflow of do_uconvert with tiny buffer sizes
- From: Grzegorz Adam Hankiewicz <gradha@xxxxxxxxxx>
- Date: Tue, 12 Aug 2003 19:50:34 +0200
On 2003-08-12, Eric Botcazou <ebotcazou@xxxxxxxxxx> wrote:
> The patch is OK for mainline, except the two following minor nits:
> - a double ASSERT on 'size' is overkill. The first one is certainly
> superfluous.
> - the patch is not complete (the change against aintern.h is missing).
Corrected and commited.
> > Running the example with the patch, an assertion in line 666
> > is raised, which is quite cool.
>
> Was this your motivation for adding the double ASSERT? :-)
Not really, my mind must have been driven by the dark side from
the beginning, I got 666 as I run the test case for the first time.