Re: [AD] Faster hsv_to_rgb() |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
> On some of these places it doesn't matter technically, since the
> conversion is at compile time,
Sure.
> but maybe you are right that it's better to be explicit.
Think of the reader who will waste his time trying to figure out why there is
sometimes 1 and sometimes 1.0f, although the situations are strictly
identical.
The other solution is to put a comment at the beginning of the code saying
"Yeah, I know, the code below badly mixes integer and floating-point
constants but I can certify this doesn't matter."
> Committed after implementing your changes and re-validated.
Thanks.
--
Eric Botcazou