[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Sat, 2003-04-05 at 23:23, Eric Botcazou wrote:
[..]
>
> +static void usage(char *_argv0)
>
> +int main(int _argc, char *_argv[])
>
> Why the underscores?
>
> + return EXIT_SUCCESS;
>
> Eh! either return 0; or exit(EXIT_SUCCESS); but not a mix of both.
>
I blame Michael Bukin for both. I really hope he doesn't mind me
dissecting all of his X11 tools.. :)
> > The patch is attached. I included it in the make process, but I have
> > some doubt about the use of 'getopt' in the original xf2pcx - there's a
> > configure check for unistd.h, so maybe I should remove getopt and use
> > the same option parsing like in the non-x11 tools?
>
> unistd.h is the POSIX header file defining close() so I don't think there are
> many Unices that don't have it. And getopt(3) is POSIX.2 so it's fine too.
>
Ok. I just wanted to be sure, I don't want to be responsible for the
Allegro build failing just because xf2pcx got included :)
> Ok with the aforementioned changes.
>
All fixed, and applied.
--
Elias Pschernig <elias@xxxxxxxxxx>