[AD] strcat strcpy etc.. BUG found!

[aj <aj@xxxxxxxxxx>]

i have noticed the src of allegro has a few strcat()  and  strcpy()
shouldnt they be replaced  with  strNcat()  and/or  strNcpy()  ?


such as in  /allegro417/src/win/wddbmp.c
around lines 128-132:


case DDERR_PRIMARYSURFACEALREADYEXISTS:
         strcpy(err_str, "DDERR_PRIMARYSURFACEALREADYEXISTS");
         break;

this is a buffer overflow !


and another suspicious one...

/allegro417/src/dos/sndscape.c (lines 378):


static int get_ini_config_entry(char *entry, char *dest, FILE *fp)
{
   char str[83];
   char tokstr[33];
   char *p;

   /* make a local copy of the entry, upper-case it */
   strcpy(tokstr, entry);

****** this strcpy looks like it could overflow **********


   strupr(tokstr);

   /* rewind the file and try to find it... */
   rewind(fp);

   for (;;) {
      /* get

--------------------

aj.