Re: [AD] grabber indexing patch

["Eric Botcazou" <ebotcazou@xxxxxxxxxx>]

> I assume, you want to change it so it has a return value indicating
> failure?

Yep.

> I also added another errno = 0, which I think should be there. But of
> course, if this is true, there are a lot of places, also in the main
> code, where errno is treated wrong. Specifically, errno being set for
> most libc functions doesn't indicate an error if the return value is 0.

Yes, we should rely only on errno to detect errors.

> I'm not really happy with it though. Maybe it's better to completely
> remove errno (except to check the type of error right after a libc
> function call returns failure) - or at least, do this for Allegro 5?

I think we should do it in the 4.1.x series.

> I could try looking for errno in the sources and fix possible problems,
> after I know which is the best solution  - but I don't have much time so
> it could take a while :) Or maybe, Eric, this is what you are doing
> already? :)

Yes, the two patches (for the core library and the dat utilities) have been
ready for some time, but I haven't tested them yet. And I want to clean up the
plugin interface first.

--
Eric Botcazou