[no subject]

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On platforms that support constructors, there is no need to call
fixup_datafile() for 8-bit BITMAPS and 8-bit RLE sprites. But this is
required for hi- and truecolor BITMAPs and RLE sprites. Moreover, since
you don't support constructors at all, calling fixup_datafile() would be
mandatory in the 4.1.x series.

I think you should make it more compatible with dat2s, so that both are
interchangeable for generating the compiled datafile of the setup program.
This would involve:
- getting rid of the '-d' option,
- changing the '-c' option into '-o',
- making both '-o' and '-h' not required,
- using 'data' as the default suffix,
- adding a constructor on platforms that support them.

Otherwise, great work! It works flawlessly for the setup program, both with
DJGPP and Mingw32.

- Eric

------=_NextPart_000_0077_01C24579.387BEC00
Content-Type: application/octet-stream;
	name="convert.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="convert.diff"

--- convert.c.orig	Fri Aug 16 14:57:12 2002
+++ convert.c	Fri Aug 16 20:01:02 2002
@@ -417,9 +417,9 @@
     fprintf(dat2c->fp_c, "    %d, %d, /* w, h */", bmp->w, bmp->h); 
         LFC();
     fprintf(dat2c->fp_c, "    0, 0, 0, 0, 0, /* clip */"); LFC();
-    fprintf(dat2c->fp_c, "    &__linear_vtable%d, /* vtable */",
+    fprintf(dat2c->fp_c, "    (GFX_VTABLE *)%d, /* bpp */",
         bmp->vtable->color_depth); LFC();
-    fprintf(dat2c->fp_c, "    _stub_bank_switch, _stub_bank_switch, "
+    fprintf(dat2c->fp_c, "    NULL, NULL, "
         "/* write_bank, read_bank */"); LFC();
     fprintf(dat2c->fp_c, "    ");
     write_lowercase_string(dat2c->fp_c, name);
@@ -650,8 +650,8 @@
     write_lowercase_string(dat2c->fp_c, name);
     fprintf(dat2c->fp_c, "_range%d,", num_ranges - 1); LFC();
     fprintf(dat2c->fp_c, "    %d, /* height */", f->height); LFC();
-    fprintf(dat2c->fp_c, "    &_font_vtable_%s", 
-        f->vtable == font_vtable_mono ? "mono" : "color"); LFC();
+    fprintf(dat2c->fp_c, "    (FONT_VTABLE *)%d /* color flag */", 
+         f->vtable == font_vtable_color ? 1 : 0); LFC();
     fprintf(dat2c->fp_c, "};"); LFC();
     
     LFC(); LFC(); LFC();

------=_NextPart_000_0077_01C24579.387BEC00--




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/