Re: [AD] Color convertors

["Eric Botcazou" <ebotcazou@xxxxxxxxxx>]

> I've been modifying the color convertors (icolconv.s) to allow working
> spans of any length (also making them faster in the process :), as
> requested by Angello for the BeOS port. It could also be useful for the
> Windows port as that tends to lock up sometimes in the convertors.

I can't believe it ;-) You swapped %ecx and %edx in the whole non-MMX code !
What for ?

IMO it's not the smartest thing to do:
- it's obviously error-prone: the crash in the 32->24 code comes from there,
- the diff file is literally illegible,
- in several places the Pentium pairing is broken, I want to fix it but now
my own material is useless.

You should have posted the diff file on the list (or upload it somewhere) so
that the author of the code (in this particular case, me) could have made
his remarks before the code was commited.

I'm going to partially revert the changes you made to the non-MMX code:
- the %ecx vs %edx swap,
- the xorl vs movl changes,
- the modifications in the 8->24 code I don't understand and that break the
pairing,

Moreover, I see you did the same thing for the MMX code: the permutation
between registers is even more complicated ! What for ?

---
Eric Botcazou
ebotcazou@xxxxxxxxxx