Re: [AD] DirectSound capturing support added

[Javier Gonzalez <xaviergonz@xxxxxxxxxx>]

I havent tested it yet, but having a look at the code...
question
1) why did you changed empity_string to EMPITY_STRING?
2) could you use /* */ comments instead of // ones? (shawn likes it that
way=
3) also could you add more blank lines between functions? (this las is also
from shawn
preferences, see alhack document for more info)
4) why have you changed the capabilities from
DSBCAPS_PRIMARYBUFFER | DSBCAPS_CTRLVOLUME;
to
DSBCAPS_CTRL3D | DSBCAPS_PRIMARYBUFFER;
that forgotten CTRLVOLUME was causing the cannot set global volume bug and
it's not
a good idea to add it again... also we are not using 3d control for nothing,
so its not neccesary

in digi_directsound_exit... you should also release voices and such when
input is true...
maybe after have stopped dsoundcapture, but you should release them as well
(i think...)

hmm, i'm detecting your file lacks many things from latest CVS... are you
sure it's based
on the LATEST? or you did deleted this:
-   switch (get_display_switch_mode()) {
-      case SWITCH_BACKAMNESIA:
-      case SWITCH_BACKGROUND:
-         dsbdesc.dwFlags |= DSBCAPS_STICKYFOCUS;
-         break;
-   }
because u wanted? cause in that case you would be broking switching code for
sound...


Take a look at what CVS version it's based on...


----- Original Message -----
From: "Nick Kochakian" <nickk@xxxxxxxxxx>
To: <conductors@xxxxxxxxxx>
Sent: Monday, March 19, 2001 12:59 AM
Subject: [AD] DirectSound capturing support added


> I've attached a file based on the current CVS version which adds sound
input
> functions to the direct sound system. I've also included a modified
version
> of akaitest, I think the way the audio data capturing is setup in that
> modified file is probably the better way to do it.
>
> - /\/ick
>