[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
> the code looks ok to me, no need to patch. there are two paths, and each
> one initializes the variables. i bet it's just yet another msvc
> idiosyncracy, it just can't handle this code, as many others :)
> your patch just brings the testing of autocrop values to the main function
> body, which is unnecessary. i think your patch won't break anything, but i
> doubt it will correct anything either, unless i'm missing something.
I don't know the first thing about this piece of code but I think that, at
least syntactically, there is a problem: suppose autocrop is set and either
tx or ty is set to a non zero value by 'bmp = crop_bitmap(bmp, &tx, &ty)'
then dat is passed uninitialized to datedit_set_property().
--
Eric Botcazou
ebotcazou@xxxxxxxxxx