[tablatures] Re: harmonics and slides II

[Patrick Schmidt <p.l.schmidt@xxxxxx>]

Am 20.12.2010 um 18:19 schrieb Carl Sorensen:

> On 12/19/10 10:20 AM, "Patrick Schmidt" <p.l.schmidt@xxxxxx> wrote:
>
> > Hi Carl,
> >
> > here is a revised patch for http://codereview.appspot.com/3590041/. I
> > don't know whether it's possible to merge the new patch with the old
> > one on rietveld... I used lily-git.tcl to make this patch. Obviously
> > all my snippet-files weren't added automatically. I didn't know that.
> > So I attached them to this email. Do I have to use git for these kind
> > of tasks? What do I have to do to upload all of this to rietveld
> > without messing anything up?
>
> git-cl takes care of the changes -- no problem.
>
> Simply do
>
> git add Documentation/snippets/new/my-new-snippet
>
> before doing
>
> git commit -a
Hm, this is what I did:

pls:~ PLS$ cd lilypond-git/
pls:~/lilypond-git PLS$ git add Documentation/snippets/new/tablature- 
open-string-harmonics.ly
pls:~/lilypond-git PLS$ git add Documentation/snippets/new/tablature- 
fretted-string-harmonics.ly
pls:~/lilypond-git PLS$ git add Documentation/snippets/new/tablature- 
slides.ly
pls:~/lilypond-git PLS$ git commit -a
Created commit 5226ca8: Selected snippets harmonics and slides II
 3 files changed, 172 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/snippets/new/tablature-fretted- 
string-harmonics.ly
 create mode 100644 Documentation/snippets/new/tablature-open-string- 
harmonics.ly
 create mode 100644 Documentation/snippets/new/tablature-slides.ly
pls:~/lilypond-git PLS$ git cl issue 3590041
Command "git config rietveld.server" failed.
You must configure your review setup by running "git cl config".
pls:~/lilypond-git PLS$ git cl config
Rietveld server (host[:port]) [codereview.appspot.com]:
CC list: lilypond-devel@xxxxxxx
Tree status URL:
ViewVC URL:
pls:~/lilypond-git PLS$ git cl issue 3590041
Issue number: 3590041 (http://codereview.appspot.com/3590041)
pls:~/lilypond-git PLS$

I can't see the new patch on rietveld. Where did I go wrong?
> > BTW: I didn't manage to write a scheme function to automatically
> > adjust length and thickness of glissandi in Voice and TabVoice
> > contexts. Sorry for that.
>
> No problem.
Thanks! :-(
> > Today I posted a bug report concerning \hideNotes in tablature. It
> > affects one of the attached snippets.
>
> This is probably a layer issue.  Hopefully we can get it sorted  
> this week.
Thanks,
patrick
> Thanks,
>
> Carl