Re: [frogs] chord_name_engraver - help with c++ ...

[Carl Sorensen <c_sorensen@xxxxxxx>]

On 7/5/11 3:06 PM, "Wols Lists" <antlists@xxxxxxxxxxxxxxx> wrote:

> On 05/07/11 21:29, Jan Warchoł wrote:
>> 2011/7/5 Wols Lists <antlists@xxxxxxxxxxxxxxx>:
>>> This frog is back ... I said I'd wait until 2.14 which has finally
>>> arrived :-) But I've revamped my code a bit and am having problems...
>> 
>> Could you send me a link to the previous discussion on this topic? A
>> quick search didn't return anything.

First email in the chain is
http://lilypond-frogs.2124236.n2.nabble.com/chord-name-engraver-plus-capo-td
5462185.html
>> 
>> 2011/7/5 Carl Sorensen <c_sorensen@xxxxxxx>:

>> 
> Patch attached. I've looked at the web page for rietveld, and I run
> gentoo so things do "just build" for me (gentoo bugs excepted :-) Do I
> need the git-cl stuff? I don't know what LilyDev is, but I guess I
> haven't got it ...

If you get git-cl, then you can easily post a patch for review on Rietveld
just by doing git-cl upload master.

Then we have a nice side-by-side diff that we can use to give you feedback.

> 
> If you look at the patch, the idea is that all of my changes (apart from
> the initial setting of bool capo) should be set inside an "if capo"
> conditional, so if the user doesn't set capoPitch, lily doesn't go
> anywhere near my code.

I'll try to give it an eyeball tonight.

Thanks,

Carl


---
----
Join the Frogs!