[frogs] Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044)

[pnorcks@xxxxxxxxx]

Hi Ian,

I just tested your patch.

In addition to the small tweak that is needed (see my comment below), it
seems that the `(use-modules (ice-9 curried-definitions))' statement
does not carry over to display-lily.scm.  I am a bit puzzled by this.

This is the error message, in context:

;;; compiling
/home/pnorcks/usr/share/lilypond/2.13.37/scm/music-functions.scm
;;; compiling
/home/pnorcks/usr/share/lilypond/2.13.37/scm/display-lily.scm
;;; WARNING: compilation of
/home/pnorcks/usr/share/lilypond/2.13.37/scm/display-lily.scm failed:
;;; key syntax-error, throw args (macroexpand "~a in ~a" ("source
expression failed to match any pattern" (define
((make-music-type-predicate-aux mtypes) expr) (if (null? mtypes) #f (or
(eqv? (car mtypes) (ly:music-property expr (quote name)))
((make-music-type-predicate-aux (cdr mtypes)) expr))))) #f)
;;; WARNING: compilation of
/home/pnorcks/usr/share/lilypond/2.13.37/scm/music-functions.scm failed:
;;; key wrong-type-arg, throw args (#f "Wrong type to apply: ~S" (#f)
(#f))


Fortunately, it seems that the Scheme interpreter in Guile 1.9 is used
as a fallback when compilation fails, since this doesn't interpret the
make process.

Can you reproduce this with Guile 1.9.13?

Thanks,
Patrick


http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode227
scm/lily.scm:227: (use-modules (ice-9 curried-definitions))))
In this section, the parenthesis nesting needs some adjustment.

It should be

  ((guile-v2)
   (if (ly:get-option 'verbose)
       (ly:message  (_ "Using (ice-9 curried-definitions) module\n")))
   (use-modules (ice-9 curried-definitions)))

http://codereview.appspot.com/2219044/

---
----
Join the Frogs!