[frogs] Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

[pnorcks@xxxxxxxxx]

Hi Ian,

I haven't tested your patch yet to make sure everything is okay, but I
have a few quick comments for you.

Thanks,
Patrick


http://www.codereview.appspot.com/1160044/diff/10001/11008
File scm/lily.scm (right):

http://www.codereview.appspot.com/1160044/diff/10001/11008#newcode250
scm/lily.scm:250: (define-public  (guile-v2 )
(define-public (guile-v2)

http://www.codereview.appspot.com/1160044/diff/10001/11008#newcode251
scm/lily.scm:251: (string>? (version) "1.8.7"))
What if the Guile team decides to release 1.8.8 ?

It would be safer to change this to some 1.9 version...

http://www.codereview.appspot.com/1160044/diff/10001/11008#newcode303
scm/lily.scm:303: (cond-expand
Shouldn't this `cond-expand' block start in column 1, and then indented
from there?

http://www.codereview.appspot.com/1160044/show

---
----
Join the Frogs!