[frogs] Re: Lilypond issues success/failure termination message (issue736041) |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
Reviewers: Patrick McCarty,
http://codereview.appspot.com/736041/diff/1/5
File scm/lily.scm (right):
http://codereview.appspot.com/736041/diff/1/5#newcode262
scm/lily.scm:262:
On 2010/03/24 21:59:22, Patrick McCarty wrote:
I removed this 'gettext wrapper because LilyPond only supports Guile
1.8.2 or
later.
Do we really want to reinstate this?
No - will revert it.
Done
http://codereview.appspot.com/736041/diff/1/5#newcode296
scm/lily.scm:296:
On 2010/03/24 21:59:22, Patrick McCarty wrote:
These commented lines should be part of a separate patch.
Done.
http://codereview.appspot.com/736041/diff/1/5#newcode763
scm/lily.scm:763: (if (= (random 40) 1)
On 2010/03/24 21:59:22, Patrick McCarty wrote:
You need to rebase again.
Done.
Description:
Lilypond issues success/failure termination message
Add a message to indicate the Lilypond has completed a compilation.
Please review this at http://codereview.appspot.com/736041/show
Affected files:
M flower/include/warn.hh
M flower/warn.cc
M lily/general-scheme.cc
M scm/lily.scm
---
----
Join the Frogs!