[frogs] Enhancement: string bends (issue216051)

[n.puttock@xxxxxxxxx]

http://codereview.appspot.com/216051/diff/1/2
File bend-implementation-roadmap.txt (right):

http://codereview.appspot.com/216051/diff/1/2#newcode21
bend-implementation-roadmap.txt:21: c4 d\bend
I see why you want to use this syntax, but it goes against the
convention for postfix notation.  Since you're creating a spanner, one
would expect the \bend command to follow the c4 (like a glissando or
tie)

Furthermore, it's rather inefficient since it requires the engraver to
cache every note in case a string-bend-event arrives at the next
timestep.

http://codereview.appspot.com/216051/diff/1/3
File lily/string-bend-engraver.cc (right):

http://codereview.appspot.com/216051/diff/1/3#newcode21
lily/string-bend-engraver.cc:21: #include "international.hh"
insert

#include "spanner.hh"

http://codereview.appspot.com/216051/diff/1/3#newcode33
lily/string-bend-engraver.cc:33: virtual void finalize();
finalize ()

http://codereview.appspot.com/216051/diff/1/3#newcode95
lily/string-bend-engraver.cc:95: "String_bend ",
StringBend

http://codereview.appspot.com/216051/diff/1/5
File ly/script-init.ly (right):

http://codereview.appspot.com/216051/diff/1/5#newcode14
ly/script-init.ly:14: bend = #(make-music 'StringBendEvent)
This should go in declarations-init.ly or property-init.ly (it's not
really clear which, since we have several similar make-music definitions
in both files)

http://codereview.appspot.com/216051/show

---
----
Join the Frogs!