| Re: [frogs] Patch for Issue #830 |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: Neil Puttock <n.puttock@xxxxxxxxx>, Marc Hohl <marc@xxxxxxxxxx>
- Subject: Re: [frogs] Patch for Issue #830
- From: Mark Polesky <markpolesky@xxxxxxxxx>
- Date: Sun, 20 Dec 2009 12:36:19 -0800 (PST)
- Cc: Carl Sorensen <c_sorensen@xxxxxxx>, Lily-Devel List <lilypond-devel@xxxxxxx>, "frogs@xxxxxxxxxxx" <frogs@xxxxxxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1261341379; bh=ZayucC9pir2ag160OZhZ1pa6O/6VaxWx+r33Vs8X+6M=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=KkiWqmlSe+3SDpY7rqcgmkaZBx3kew2CYNNoFPed0iiKF0oJJBvd/qnSmVKJn/JstyA5a1BjS38qdv1tDt8uLAo2W3fKPPVmLoOra/94tBszBuKhLY8fu38EpFlLl5mLtioAyKVHom6A6TWltBxbbORImxDB4a12oMLL3xYm8ys=
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=4EJFVTXNSKugvJerLq8z/v/hO5aP46AbFDmCfg2RzxOEaz268uoCsk6/Nv1vV5Pvo/0fG0d/n62oQLJHiSV6rCWfpbo49Li1GgeD7KZ7c1QCzMH7kR7TMtVBm5+F3iqKzC+awli842GfKF+/6JKG9gIRrgCa2eMqEtenUu8Zawg=;
Marc Hohl wrote:
> I have renamed the feta-*.mf files accordingly (see issue
> #830). I did
>
> make clean
> make all
>
> and didn't get any errors. Ok to apply?
I don't see any problems looking at the patch, but that
doesn't mean there aren't any. I'll let Neil or Carl weigh
in here.
One recommendation: every time you modify a source file, run
a macro or something to trim the trailing whitespaces
(applying this patch triggered some git warnings). In this
case, it's clear that you didn't *add* them (they were in
the original files), but even so, patches will apply more
cleanly if you make sure to remove them.
What text editor are you using?
- Mark
**********
$ git apply 0001-Issue-830-renaming-mf-files.patch
[...]-files.patch:144: trailing whitespace.
%
[...]-files.patch:469: trailing whitespace.
labels (5, 6, 7, 8);
[...]-files.patch:1080: trailing whitespace.
set_char_box (0, 1.6 staff_space#,
[...]-files.patch:4256: trailing whitespace.
[...]-files.patch:4270: trailing whitespace.
warning: squelched 37 whitespace errors
warning: 42 lines add whitespace errors.
---
----
Join the Frogs!