Re: [frogs] [PATCH]: Tracker 836 - Allow output filename and output-suffix to be specified for a \book block

[Ian Hulin <ian@xxxxxxxxxxxx>]

Carl,
Thanks for the pointers - I'm just going through the list to update the patch, so I'll look through all your feedback later. 
Just one remark on this point:

Carl Sorensen wrote:

+            (ly:parser-lookup parser 'book-filename))))

book-filename)))
    

You already had the result of (ly:parser-lookup parser 'book-filename),
so there's no need to do the call again.

  

Yes I do - Scheme yells at me with an 'invalid type' message if I try to re-use the local variable here.  The code that looks vile works, the code that looks right doesn't.

Cheers,
Ian