Re: [frogs] [PATCH] : Supply missing documentation strings in music-function-init.ly

[Ian Hulin <ian@xxxxxxxxxxxx>]

Neil Puttock wrote:

2009/10/20 Ian Hulin <ian@xxxxxxxxxxxx>:
  

Please push if these changes look OK.
    

Hmm, this looks suspiciously like one of the patches you posted last
month, but missing some of the changes I suggested.
  

Cor, blimey, guv'nor, you've got me banged to rights (serves me right for trying to tidy up my git repository).

+#(use-modules (ice-9 q))

I can't see any procedures from this module in init.ly.
  

Changed from another patch I was working on, reverted for this patch.

+#(define output-count 0)            % Now only used in regression tests

This isn't user serviceable any more, so you might as well clear out
all remaining references to it (and the obsolete code).
  

Removed.  The only remaining thing I could see in git which used it was a regression test where the whole lot of code was commented out (input/regression/backend-svg.ly).  Reinhold has already changed the regression test where it is actually used.

+(_i "Take the music in @var{part1} and @var{part2} and typeset so
that they share a staff")

staff.")

+(_i "Print a trill with @var{main-note} as the main note of the trill and

trailing space, docstring goes after predicate list

+print @var{secondary-note} as stemless note head in paretheses")

parentheses.")

+(_i "Indicate a section of music to be quoted.  @var{what} indicates the name

trailing space, docstring goes after predicate list

+of the quoted voice, as specified in a @code{\addquote} command.

trailing spaces, @code{\\addQuote}

+(_i "Set up a custom style of dash pattern for @var{dash-fraction} ratio of

trailing space

+(_i "Set up a custom style of dash pattern for @var{dash-fraction} ratio of

trailing space
  

All these are re-applied.

In all cases, the indentation needs fixing.
  

Have run the code through the Frescobaldi indent tool.

Now is it OK to push?

Cheers,
Ian