| [frogs] patch for bug 729 |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: lilypond-devel <lilypond-devel@xxxxxxx>, frogs@xxxxxxxxxxx, bug-lilypond@xxxxxxx
- Subject: [frogs] patch for bug 729
- From: Andrew Hawryluk <ahawryluk@xxxxxxxxx>
- Date: Fri, 27 Feb 2009 09:22:54 -0700
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=6I9+k0r3hSLUNhykUCBrt57V/kuKkGabqQ7YmP4O/Js=; b=BgmeV4QmzVW4LwKJgRL3lwWKbyCtGejADNx286IijNSqf+yxEnSHb/tXo/DygbD2+a cs4+JQP0Hw5QeW/6Ezny28U9bzd6vKXn9Ax71vm3ilFUcatgZ6lKZoKLMV4Rd8OpPShK j1pwXKjNx2olBHIgVWfnPMjC4SDwFwNIVgPf4=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=Ra2Ntino0okpsiTYpBHtX+IfLuQvzp4oeintR8Q1rKFA7ePRkeQxnDvMWV2dBt7AsA qu8rW1tuCHZzrd4FeWP1WpmcwvXzU1Y2aG1Dt57VaBYcSJIRooXhNpbi19rhVX2peVHY eJTSgZ6/GzGys0GL0RxSq89NX256HI+T5lqWw=
Attached is my fix for bug #729 and a convert-ly rule.
http://code.google.com/p/lilypond/issues/detail?id=729
If I can keep finding bugs that simple, I'll be sending patches weekly!
Andrew
From 2311c16f64a21247017cd0dafca5a177f676e506 Mon Sep 17 00:00:00 2001
From: Andrew Hawryluk <ahawryluk@xxxxxxxxx>
Date: Fri, 27 Feb 2009 09:15:19 -0700
Subject: [PATCH] MIDI 47: orchestral strings -> orchestral harp
---
python/convertrules.py | 5 ++++-
scm/midi.scm | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/python/convertrules.py b/python/convertrules.py
index 574e64b..d27be1f 100644
--- a/python/convertrules.py
+++ b/python/convertrules.py
@@ -2874,14 +2874,17 @@ def conv(str):
raise FatalConversionError ()
return str
-@rule ((2, 13, 0), _ ("keySignature property not reversed any more"))
+@rule ((2, 13, 0), _ ("keySignature property not reversed any more,\n\
+MIDI instrument #47 orchestral strings -> orchestral harp"))
def conv(str):
if re.search(r'\set Staff.keySignature', str):
stderr_write ("\n")
stderr_write (NOT_SMART % _("The alist for Staff.keySignature is no \
longer in reversed order.\n"))
+ str = str.replace('#"orchestral strings"', '#"orchestral harp"')
return str
+
# Guidelines to write rules (please keep this at the end of this file)
#
# - keep at most one rule per version; if several conversions should be done,
diff --git a/scm/midi.scm b/scm/midi.scm
index cb0c0e6..5e956d1 100644
--- a/scm/midi.scm
+++ b/scm/midi.scm
@@ -122,7 +122,7 @@
("contrabass" . ,(- 44 1))
("tremolo strings" . ,(- 45 1))
("pizzicato strings" . ,(- 46 1))
- ("orchestral strings" . ,(- 47 1))
+ ("orchestral harp" . ,(- 47 1))
("timpani" . ,(- 48 1))
; (49-56 ensemble)
--
1.5.6.3