| Re: [frogs] Assignment #1 |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: frogs@xxxxxxxxxxx
- Subject: Re: [frogs] Assignment #1
- From: "Andrew Hawryluk" <ahawryluk@xxxxxxxxx>
- Date: Sun, 11 Jan 2009 21:56:22 -0700
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=4FputK2mglpvrhuiNQ/v92Snb+C6Poffixks96+/2zY=; b=noI5ShHKhn/13aPvkANdLWuBthgS0A04Qk39YhHFFJ5KCJsw7jB4TJ7U+a8J9JvOmd 9oxnqMUY7cuADYWtU6evGpZDghhONd5CdyIf6BH6CrjPbxDpmLMRCVAdk2xBK67TlcX/ n1nb2+MxWSALnQkhEBsn+Coo1ZRacMZPLE18w=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=af0PAFhJsV+etfAGvjg9o1+9XTOgLB93yvjxrmWLfpvy5e6q54iU2hrZ+FnN2SJx8r RESCmHJpznak6iOhLq+s6xpAQMi2a2Vay5L5LkhlAn6BOcy8/ML2UVGsopLC2oqSB7bi 9LlIAzyC54TjBFRX47DMezVexY4ZO6pXzbB1E=
Yes. I shall do that. Glad to hear that I got the patch right!
On Sat, Jan 10, 2009 at 8:06 AM, Carl D. Sorensen <c_sorensen@xxxxxxx> wrote:
>
>
>
> On 1/9/09 12:34 PM, "Andrew Hawryluk" <ahawryluk@xxxxxxxxx> wrote:
>
>> Hi Carl et al.,
>>
>> Here's my eight doc strings, including one that will require the new
>> def-grace-function.
>
> Andrew,
>
> Thanks for this work. The patch is formatted properly, and the docstrings
> have been set for internationalization (including adding it to the one for
> addChordShape).
>
> An ideal docstring will include the parameters to the function in the call.
>
> So, for example,
> addQuote =
> #(define-music-function (parser location name music) (string? ly:music?)
> - (_i "Add a piece of music to be quoted ")
> + (_i "Add a piece of music to be quoted")
>
> Should probably be modified to something like
>
> addQuote =
> #(define-music-function (parser location name music) (string? ly:music?)
> - (_i "Add a piece of music to be quoted ")
> + (_i "Add @code{music} as a quotable fragment named @code{name}.")
>
> Can you check all of your docstrings to see that they include the arguments?
>
> Thanks,
>
> Carl
>
>
> ---
>
> ----
> Join the Frogs!
>
---
----
Join the Frogs!