| Re: [chrony-dev] [PATCH] ntp: ignore unknown link speed when updating interface |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: JR Lanteigne <root@xxxxxxxx>
- Subject: Re: [chrony-dev] [PATCH] ntp: ignore unknown link speed when updating interface
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Thu, 27 Aug 2026 09:00:39 +0200
- Cc: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787814047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l/OSjeZ3YJoS5N93dS96RR5pKyRXOy6bWDkF8xKLWn4=; b=JV+0HORjLk3JLXtb4tO8EQCjKXtp38diFBvDMqPNwaB4462Fehg55PclsiJ0+FNFzlOZam SbAamii7v0IudG/usgXwFxx2EGkzNJbbcDuyLxheTi/2qz9ep3OzGEYsRL+BDQVWBx4dD9 98g3gUguuHoXcYxFEtMBez9l4k8kAcY=
On Wed, Aug 26, 2026 at 09:28:20PM -0300, JR Lanteigne wrote:
> The ETHTOOL_GSET ioctl can report the speed as -1 (SPEED_UNKNOWN)
> while the link is down or autonegotiating. The value passes the
> nonzero check and is latched until the next update, up to 2^minpoll
> seconds after the link is back up, corrupting the RX timestamp
> correction of packets received in that interval (-752 us instead of
> +7.5 us for a 94-octet frame at 100 Mb/s).
>
> Ignore non-positive speeds to keep the last known speed.
Looks good to me. Thanks.
I'm planning to release 4.9 today and this will be included.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.