| Re: [chrony-dev] [PATCH] ntp: fall back to message if_index if timestamping if_index is 0 |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Subject: Re: [chrony-dev] [PATCH] ntp: fall back to message if_index if timestamping if_index is 0
- From: JR Lanteigne <root@xxxxxxxx>
- Date: Mon, 24 Aug 2026 13:16:49 -0300
- Cc: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dnim.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1787588210; x=1787674610; bh=adAUFS2C8bqVS0XLNuCRmjQgm63x5qawGSx8v7Er5x8=; b= zTZtcJ91e7yIfBu5IN25RLmFJnwYdUIJijMprIYNaRrU2U2QxS9bnv3RDqTDEvdo 5rSBfA1bpVlw7EEFwubLYi5yEnJO1M7Ghca0BiqM+Sc+o8+JsEGmpBBU99dJbIMF zDhdrM7vXIUdAML9SQYT4rI+b/uaNUWn6Rffz7sDuDUHTqd4d06V9Juan5yY+8MO rScVnf4gfTRWDSUxXVQiowDe1EK3+W6f+2m8Z3YEovmGz2+11YCICmDyb06xoUHJ CrXoRnMCEGQAqYYkpZBXAhZyS99A4A14LMyhfhyC3VeO9qs6/pR51BY5sXwhXf6o p/IYJ/BXfHnTPVvRuS60Ww==
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1787588210; x= 1787674610; bh=adAUFS2C8bqVS0XLNuCRmjQgm63x5qawGSx8v7Er5x8=; b=U 68YHWOFao0kVC9y6dP2JfnC+uQk1L/7Ug3zZ1zIfh5iOJaN8X3OJzjao2gjEZoQI b7DnjPzEDQPie0MgVi7jI9z8uSLKg9M1qSCnhL7Ptvnl/mNN8ljlvtYX4Vqh4FIM IXauzjt/6NeB/QayQ2v1hL9zqlXh0k2JtBVk+8D889tEzKBJmRlEVIXcbrTjmMth GrrPh9dxtxSW059c/CPc7LVpg5TQuUI1XsiPf0VlA0tKb+JqGemctiwNB9hkRCNd fOQCmO6aBGIdqnWG4W6HY6e8rMrWzNDXstC594wfWgCb5DtbLXABfmADvvMdSFQU BwYrFOXyxM1cd+daZNMjg==
- Feedback-id: i14ee4b4c:Fastmail
Miroslav Lichvar wrote:
> One thing that is not clear to me, how could this bug impact transmit
> timestamps? The SCM_TIMESTAMPING_PKTINFO option should apply only to
> received packets, at least that's what it originally was support to do.
You're right, it doesn't. The fix is RX-only. TX resolves through
the error queue IP_PKTINFO, which carries the egress interface, and
never saw the zero if_index.
The before/after in my note is misleading, and I should have caught
it: it spans bringing up the hardware timestamps at all, not just
this fix. This board's CPTS stamps only PTP frames, so NTP is
stamped by a PRU core on the GPS PPS timebase, fed into the kernel
paths by a small module that went live the same night. TX read
hardware as soon as that landed; only RX needed the zero check.
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.