| Re: [chrony-dev] [Git][chrony/chrony][master] 7 commits: doc: improve description of logbanner |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [Git][chrony/chrony][master] 7 commits: doc: improve description of logbanner
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Mon, 5 May 2025 12:34:23 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746441269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oVV/hb+JHs0pJOL2ONgo2+wATCsgXfgnJZ5iTC+29z4=; b=Tjb58Vu3Uc2k3BCQVcoADSi5ruUUzVPhLmnx/Jd0cSnVMpxwTVA8p3zrbh/kswMx8D4JyW faxKoYNcVaLkgtvlz+G5cgjWAOzny8DPVB30t3jhKTLtRyWqICwAknnJDos5ouxwtHy0jW n3jAC9s79innnc5yvjuTk3qPlegsASY=
On Thu, May 01, 2025 at 09:36:28AM +1200, Bryan Christianson wrote:
> macOS does not declare SOCK_CLOEXEC and SOCK_NONBLOCK. I think the following patch will correct the warning.
>
> diff --git a/socket.c b/socket.c
> index d08b865..c5d15a7 100644
> --- a/socket.c
> +++ b/socket.c
> @@ -44,6 +44,11 @@
> #include "ptp.h"
> #include "util.h"
> +#ifdef MACOSX
> +#define SOCK_CLOEXEC FD_CLOEXEC
> +#define SOCK_NONBLOCK O_NONBLOCK
> +#endif
> +
That might fix the compilation, but I don't think it's right to pass
an open() or ioctl() flag to socket().
I disabled the function when not used.
Thanks for the report.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.