[chrony-dev] [Git][chrony/chrony][master] 2 commits: refclock: fix build on non-Linux systems

[ Thread Index | Date Index | More chrony.tuxfamily.org/chrony-dev Archives ]


Title: GitLab

Miroslav Lichvar pushed to branch master at chrony / chrony

Commits:

  • a90a7cf5
    by Bryan Christianson at 2024-12-10T10:14:43+01:00
    refclock: fix build on non-Linux systems
    
    Fixes: 5fd71e27831f ("refclock: add new refclock for RTCs")
    
  • 8ee725ff
    by Miroslav Lichvar at 2024-12-11T11:45:13+01:00
    refclock: drop filter length adjustment for polling drivers
    
    In the refclock initialization, if the driver provides a poll()
    function and 2^(poll-dpoll) is smaller than the configured length of the
    median filter (64 by default), the filter is shortened to 2^(poll-dpoll)
    samples, assuming the driver provides samples only in the poll()
    function and at most one per call, to avoid wasting memory and before
    commit 12237bf28393 ("refclock: stop requiring 4 samples in median
    filter") also simplify configuration (for polling drivers only)
    
    But this assumption is not always correct. The PHC driver can read
    external PPS timestamps independently from the driver polling and the
    RTC driver can timestamp interrupts. If the dpoll was too large to cover
    the sample rate, some samples would be lost.
    
    Drop the adjustment of the filter length to avoid this unexpected impact
    on filtering and make it work as documented.
    

2 changed files:



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/