[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH]
- From: Andy Fiddaman <illumos@xxxxxxxxxxxx>
- Date: Thu, 21 Mar 2024 18:50:36 +0000 (UTC)
- Authentication-results: citrusmail; dkim=pass header.i=@fiddaman.net
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiddaman.net; s=boomer; t=1711047040; bh=jfGFaGkTcaxgDxHcuIQvbr0jU+XTZirhU30OpdiPaAs=; h=Date:From:To:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=EQikayHGFU/AHXyqk6AT+TF18Cfc3ugIvcYaCY5eYYBQg64ryNPtfHe1zd9MM4WD7 wy0PhcGRHGBKD3759RCCruvBW01edzcUMRTIhTSR7F02rpCoyC23MFNPT7qaS6YGR6 68GG9nAjCJP7+afkJmkQiBNVxxMqXW7IIRBx4rxo=
On Thu, 21 Mar 2024, Miroslav Lichvar wrote:
> I was going to respond to your pull request on github, I just had
> other things to do earlier.
I noticed that the github repo is marked as a mirror, and that most
discussion is on the mailing list so I switched to here. I am happy
to continue wherever is most convenient for you, and thank you for
replying.
> On Thu, Mar 21, 2024 at 12:18:02PM +0000, Andy Fiddaman wrote:
> > There is a bootstrapping problem, however. If the system comes up without
> > external connectivity, then the two boundary servers authoritatively
> > advertise 1986 at stratum 10. There are also several other scenarios we've
> > encountered that can occur depending on the state of connectivity.
> >
> > This patch adds two new options to "local" to help in these situations.
> >
> > The first, "local oncesynced" prevents the local reference being activated
> > unless time was synchronised at some point in the past.
>
> This makes sense to me, although I think it might be better to
> generalize it as an activating root distance, which would completement
> the distance option (threshold).
Oh, I like that idea. Shall I re-work the patch in those terms?
Any thoughts on a good name for the keyword?
> > The second, "local mintime" prevents the local reference being activated
> > unless the system clock is later than the specified time.
>
> Can you please explain why both options are needed? This seems more
> like a hack, that should have a better solution than making
> assumptions about absolute time.
This was the first thing I added, with the idea that we would set
the threshold to something that is before we ever shipped any
systems. With the other option, it is just belt and braces now
and not necessary. I can remove it along with the reworking above.
Andy
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.