| Re: [chrony-dev] [PATCH v2 5/6] leapdb: support leap-seconds.list as second source |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH v2 5/6] leapdb: support leap-seconds.list as second source
- From: Patrick Oppenlander <patrick.oppenlander@xxxxxxxxx>
- Date: Thu, 7 Dec 2023 13:04:26 +1100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701914677; x=1702519477; darn=chrony.tuxfamily.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=X4yLQggpo/4HmRAST0M6+qWJTtbOTwI+GcqJ6JZdfO8=; b=nnYFw2apdpun8fIJFqAz3edaV14OUT4f6+5Wx8eCVM9aFh3aJONzCZkrT0X//8v5aZ 8QLZWYmBK3yINmdgvTM0VaGuLwxqjNw/fjqK/cbu1iMJIMuI61MpsAFQtku4w3V28hVI 0CENTd+Ht1fEHUMH5uwUOEL/j543UMi4o2Q11WO96MqFvWwUpkwamM2QnqxUWHIIynEu CIm/e+j7Djr6tKdsu4JHPvLPkDLzjm/KoYDzibfucXN0zg13IpXtR53v8V2c41aaBSnd QosM4QL2bc76coumlD7PMGy30WJyFg5XoZGGP5FNaUlMCYlGSdRB/C9voO3vggrrSPxG 6uXA==
On Thu, Dec 7, 2023 at 12:48 AM Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>
> On Thu, Nov 30, 2023 at 02:23:28PM +1100, patrick.oppenlander@xxxxxxxxx wrote:
> > +/* Leap second database */
> > +struct leapdb {
> > + long long updated;
> > + long long expiry;
> > + size_t len;
> > + struct leap {
> > + long long when;
> > + int tai_offset;
> > + } leap[];
> > +};
>
> Please avoid saving the data in memory. I think the requested leap can
> be found in one pass over the file. Simpler is better.
Agreed, simple is good. Thanks for the feedback, I'll prepare a v3.
Patrick
> --
> Miroslav Lichvar
>
>
> --
> To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
> For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
> Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.
>
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.