Re: [chrony-dev] [Git][chrony/chrony][master] 2 commits: ntp: initialize network correction of transmitted packets

[Luke Valenta <lvalenta@xxxxxxxxxxxxxx>]

Oops, this should fix the compiler warning: https://gitlab.com/chrony/chrony/-/merge_requests/7

Thanks,

Luke

On Tue, Nov 7, 2023 at 2:36 PM Bryan Christianson <bryan@xxxxxxxxxxxxx> wrote:

Getting a compiler warning on macOS


gcc -O2 -g -fstack-protector-strong --param=ssp-buffer-size=4 -Wmissing-prototypes -Wall -pthread  -c logging.c
logging.c:72:19: warning: unused variable 'severity_chars' [-Wunused-const-variable]
static const char severity_chars[LOGS_FATAL - LOGS_DEBUG + 1] = {'D', 'I', 'W', 'E', 'F'};
                  ^
1 warning generated.


% gcc --version
Apple clang version 15.0.0 (clang-1500.0.40.1)
Target: x86_64-apple-darwin22.6.0


> On 8/11/2023, at 03:49, Miroslav Lichvar (@mlichvar) <gitlab@xxxxxxxxxxxxx> wrote:
>
> Miroslav Lichvar pushed to branch master at chrony / chronyCommits:
>     • 51a621bc
> by Miroslav Lichvar at 2023-11-02T12:53:00+01:00 ntp: initialize network correction of transmitted packets
>
> Initialize the unused value of network correction parsed from
> own transmitted packets to avoid a use-of-uninitialized-value error
> in NIO_UnwrapMessage() reported by clang.
>
> Fixes: 6372a9f93f59 ("ntp: save PTP correction from NTP-over-PTP messages")
>
>     • f6f1863f
> by Luke Valenta at 2023-11-07T15:43:57+01:00 logging: add log severity to file log prefix when debug is enabled
>
> 2 changed files:
>     • logging.c
>     • ntp_io_linux.c
>
> —
> View it on GitLab.
> You're receiving this email because of your account on gitlab.com. Manage all notifications · Help


Bryan Christianson
bryan@xxxxxxxxxxxxx




--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.

--

Luke Valenta

Systems Engineer - Research