Re: [chrony-dev] [GIT] chrony/chrony.git branch master updated. 4.3-32-gbadaa83

[ Thread Index | Date Index | More chrony.tuxfamily.org/chrony-dev Archives ]


Here is a simple test along the lines of this issue:

#if 0
#define A(x)    (x)
#endif

#if defined(A) && A(1)
one
#endif

Try running the preprocessor on it:

% clang -E test.c
# 1 "test.c"
# 1 "<built-in>" 1
# 1 "<built-in>" 3
# 382 "<built-in>" 3
# 1 "<command line>" 1
# 1 "<built-in>" 2
# 1 "test.c" 2
test.c:5:19: error: function-like macro 'A' is not defined

Try it on linux using gcc:

% cc -E test.c

# 0 "test.c"
# 0 "<built-in>"
# 0 "<command-line>"
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 0 "<command-line>" 2
# 1 "test.c"

test.c:5:20: error: missing binary operator before token "("

I think that this preprocessor scheme is flawed.

On Wed, Jan 18, 2023 at 9:14 AM Bryan Christianson <bryan@xxxxxxxxxxxxx> wrote:
>
> Hi Miroslav
>
> This change does not compile on macOS.
>
> refclock_sock.c:64:32: error: function-like macro '__GLIBC_PREREQ' is not defined
> #if defined(__GLIBC_PREREQ) && __GLIBC_PREREQ(2, 34) && __TIMESIZE == 32
>                                ^
>
> gcc --version
> Apple clang version 14.0.0 (clang-1400.0.29.202)
> Target: x86_64-apple-darwin22.2.0
> Thread model: posix
> InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
>
> Regards, Bryan
>
> >
> > - Log -----------------------------------------------------------------
> > commit badaa83c319ae5a0bef872d1e7a55bf1260c1b84
> > Author: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
> > Date:   Wed Jan 18 16:14:10 2023 +0100
> >
> >    refclock: convert mismatched timeval in SOCK messages
> >
>
> Bryan Christianson
> bryan@xxxxxxxxxxxxx
>
>
>
>
> --
> To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
> For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
> Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.
>

-- 
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/