[chrony-dev] Re: [PATCH v4] faq: Diagnose problem with RTC interrupts on Linux |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Subject: [chrony-dev] Re: [PATCH v4] faq: Diagnose problem with RTC interrupts on Linux
- From: Michael Witten <mfwitten@xxxxxxxxx>
- Date: Mon, 14 Dec 2020 23:20:00 +0000
- Cc: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:date:from:to:cc:message-id:in-reply-to:references; bh=5aHbTY+2AqfJzWvQzztK1bRdCNkuUY2PIbsCyLwPWX4=; b=ZvO6eb01EPKaXRtc1z4c198s0oTWyGzgNT8c5CFCJdLJlaU/6Nn7JYokOEF4rhBwcs hjOcsCS/OZBgMca2tvQPCmZLovlgI6ouZOiKCDTgJksBGRkQfGQY2I45OaA8vq5WWXgr Q48nMY3Ls96bFC0LJ5NEKvuGguMhae5NlNca3gAJu9ZttngHCMbbAwG+hEnPGvNtAZzK 2Zso3w35vaoc79qm5CxJ01oOfHqpDfxF4DLhQy9HyxgeMDWAPPxw4QZBCerD8kpHHcPp k3cp2aoSJb8v6HmUHeYo8ZvRwWoqV/3xogjc5j88ZKUJO9gM+tzRgIJDBORmqrnPw+bi iKkw==
Sigh (laugh?). Sorry for further confusion.
The patch is correct.
However, the email description of the fix is not correct.
Namely, I wrote:
> Clearly, I was mistaken; this updated version of the patch
> introduces the requested log message.
>
> if (driver.init) {
> if ((driver.init)()) {
> driver_initialised = 1;
> + } else {
> + LOG(LOGS_ERR, "The RTC driver could not be initialised");
> }
> } else {
> LOG(LOGS_ERR, "RTC not supported on this operating system");
Fortunately, the patch itself includes the requested error message
(with "The" removed):
if (driver.init) {
if ((driver.init)()) {
driver_initialised = 1;
+ } else {
+ LOG(LOGS_ERR, "RTC driver could not be initialised");
}
} else {
LOG(LOGS_ERR, "RTC not supported on this operating system");
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.