| Re: [chrony-dev] [PATCH] sys_timex: add workaround for broken ntp_adjtime() on macOS |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH] sys_timex: add workaround for broken ntp_adjtime() on macOS
- From: Bryan Christianson <bryan@xxxxxxxxxxxxx>
- Date: Thu, 15 Oct 2020 20:18:23 +1300
- Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpcorp.com; s=a1-4; h=Feedback-ID:X-Smtpcorp-Track:Message-Id:To:Date: Subject:From:Reply-To:Sender:List-Unsubscribe; bh=daYHLhYv1XbmZ2RXj9tetHaZFmS6Gv018KyKnKgC0no=; b=3lMj4Cat60vCPWERgBY/gdzFzB VnMWLxco12sjtAuVAXeA95WrHbFXnd9Gwd1ttCkxIsiOZCXxphq5Bt2Ziy4mclmVvptc6FN1DuA1L VkdVngDYJqJGH8HAu9r21i9OAnCucMtYImlRQIecMpKV/culPOYPZOzmpOFaANZGF8wqEAmFlnn/d 2E3adQB824puWbBfodBsXY2qok7aQB0fJPNm2hKNQfaid+jwHKPO9IDwcqKQPQgHEgCq/MDkTUuKT 5retT4MQ5lSV89chWCr2HMXmDOEt6PEy2vrWh1/jZVb0BD8t2JfkEcgh41flObqStLt0UQryyGv7U zBQC+bbQ==;
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whatroute.net; i=@whatroute.net; q=dns/txt; s=s149811; t=1602746316; h=from : subject : to : message-id : date; bh=daYHLhYv1XbmZ2RXj9tetHaZFmS6Gv018KyKnKgC0no=; b=CI/jijy25mGtNlKYqq3Ujq5ml3iMTAYBFQfjyfEG281Y175FpkHhrl96sn6T7TsM3ULJgv zkbtVkFHFHTFf8+WCWRLAFZwrGyGkrlKXvFJ8xADlafnTBvCCi8wEbTTYJ/mRjfQLSqez4rB gyspZsFC/bmdKcneOUGcIclxNtyVCrTCLIHqb198U5VnOExusOWm+JEWSALqfGd/jiXRIxSh 6JszGQZ0WiFl4vkBknkuwe5tYSy64yuF42w7HU4w8SgzCUk3Kar0VJsVPLpkJSdYHihfFDB/ zhcpbz+Q/hGCgD39KAAxNDiNzf07KQ0ldGD0xTJ400iq7b3BwQZCwKhQ==
- Feedback-id: 149811m:149811acx33YQ:149811sbYPzVs96N
The latest beta release of macOS 11.0 (Big Sur beta 10) seems to have fixed the signed/unsigned confusion. The final release of the OS will be sometime in the next month, so I suggest waiting until then before reverting the workaround patch.
Bryan
> On 31/08/2020, at 8:37 PM, Bryan Christianson <bryan@xxxxxxxxxxxxx> wrote:
>
> Hi Miroslav
>
>> On 31/08/2020, at 8:27 PM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>>
>> Hopefully Apple will fix this soon. It's interesting they had a
>> signed/unsigned bug in both adjtime() and ntp_adjtime().
>
> I submitted a very simple test case to them - it works correctly in 10.15 and fails in 11.0. Whether or not they acknowledge it is a bug remains to be seen, although they were pretty prompt in fixing adjtime() once the error was reported.
>
> In the test, I had run time warnings (from asan and friends) with i << 16 - it didnt like i being a -ve number, so I made the additional tweak of i * (1 << 16)
>
> Bryan Christianson
> bryan@xxxxxxxxxxxxx
>
>
>
>
> --
> To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
> For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
> Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.
>
Bryan Christianson
bryan@xxxxxxxxxxxxx
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.